<h1 id="mr-pr-submission-standard">MR (PR) submission standard<a aria-hidden="true" class="anchor-heading icon-link" href="#mr-pr-submission-standard"></a></h1>
<p><a href="https://news.ycombinator.com/item?id=30578033">https://news.ycombinator.com/item?id=30578033</a></p>
<h1 id="paradite">paradite<a aria-hidden="true" class="anchor-heading icon-link" href="#paradite"></a></h1>
<p>I'm a senior frontend engineer doing a lot of code reviews and my team loves my MR (PR) submission standard:</p>
<ul>
<li>Require the author to attach screenshots of the feature in a markdown table format showing the before and after comparison. This is enforced using a MR template.</li>
<li>Require the author to attach screen recording for complex user interactions.</li>
</ul>
<p>Overall effect is that it saves everyone's time.</p>
<ul>
<li>The author has to verify that the feature works anyway, so taking screenshots / recordings doesn't take much additional efforts.</li>
<li>The reviewer can focus on code itself instead of checking whether the code works.</li>
<li>Easy for both parties to spot design and UX issues/regressions visually.</li>
</ul>
<h2 id="bradwood">bradwood<a aria-hidden="true" class="anchor-heading icon-link" href="#bradwood"></a></h2>
<p>Code review != Testing.
A lot of people conflate these IMHO. Code review should not really be about whether it "works" or not. That's what tests are for.</p>
<p>Code reviews are about checking for code complexity, good use of abstractions, readability, etc.</p>

MR (PR) submission standard


Hi there 👋. I'm a Front-end developer.

---

> I've often described my motivation for building software to others using imagery: I like to go find a secluded beach, build a large, magnificent sand castle, and then walk away. Will anyone notice? Probably not. Will the waves eventually destroy it? Yep. Did I still get immense satisfaction? Absolutely.
>
> — [aliasxneo](https://news.ycombinator.com/item?id=41497113)

> “Motivation often comes after starting, not before. Action produces momentum.”
>
> — James Clear

> Focus is more about **not** keeping busy when you need to wait for something.  
> Eat the boredom for a minute.
>
> — [[life-tips#wodenokoto]]

> [4 minutes run hard enough to push heart rate to 90%, 3 minutes recover, repeat 4 times](https://news.ycombinator.com/item?id=34213181)
>
> - https://www.ntnu.edu/cerg/advice
> - [Get running with Couch to 5K](https://www.nhs.uk/live-well/exercise/running-and-aerobic-exercises/get-running-with-couch-to-5k/)

> [recommended routine - bodyweightfitness](https://www.reddit.com/r/bodyweightfitness/wiki/kb/recommended_routine/) - I Don't Have This Much Time!
>
> - Don't workout at all (saves anywhere from 20 to 60 minutes, but really, really, really, really, really, really, really, really, really not recommended)

> [Just 4 pages a day. It really adds up.](https://news.ycombinator.com/item?id=34779980)

> I think it should be everyone's primary focus to sleep well, drink water, get outside, get active, and eat generally decently. I hate to say it, but if you're not eating a good amount of vegetables and fruit, decent protein, sleep, etc, no amount of XYZ will catch up to that detriment.
>
> — [CE02](https://news.ycombinator.com/item?id=35056071)

> Before leaving for the day I leave a comment in code: I’m working on this, need to do A, B C… to get it working.
>
> — [makz](https://news.ycombinator.com/item?id=40744916)

---

## What I read in past

- [[What I read in 2024|journal.what-i-read-in]]
  - [[2023|journal.what-i-read-in.2023]]
  - [[2022|journal.what-i-read-in.2022]]
- 📝 [Gists](https://gist.github.com/Luke-SNAW)
- 📜 [Journals](https://luke-snaw.github.io/Luke-SNAW__netlify-CMS.github.io/)

---

- [[journal.what-i-struggled-brag-in]]
